[Ffmpeg-devel] [PATCH] Add fact chunk to non-PCM wav

[Michel Bardiaux]

Michael Niedermayer wrote:
> Hi
> 
[snip]

>>>> BTW I feel that the 'assert' should be hunted down even more
>>>> ruthlessly as the dprintf. What do you think?
>>> some asserts are inappropriate they surely should be hunted down,
>>> others are valid and should not
>> I meant 'hunt assert to replace it by if+av_log+appropriate rror 
>> return'. Most people 'configure' in such a way that 'assert' is a
>> nop.
> 
> and correct asserts should never be false so a nop is all fine of
> course one checking function parameters from exported functions is
> not correct ...

I dont understand you at all, which is usually a sign I should let the 
matters percolate through my dura mater for a few millenia...

> 
> patch looks ok except that minpts should be initalized to INT64_MAX
> it does nothing otherwise
> 
Right, and since I made my tests using PCM s8 file as input, it did not
matter because the min pts was zero anyway. Ecco.

Greetings,
-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: lavf_fact_3.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070212/f59ef23f/attachment.asc>