[Ffmpeg-devel] [PATCH] access all bitrates for amr nb encoding

[Benoit Fouet]

Benoit Fouet wrote:
>>>>> well, i'm coming with the beginning of something...
>>>>> the problem is that audio and video bitrate are crushing one another...
>>>>>
>>>>> for instance launching a ffmpeg with a -b and -ab options, the last of
>>>>> the two options will be taken into acount...
>>>>> the question is: "is it the right place to add the ab option handling ?"
>>>>>     
>>>>>         
>>>>>           
>>>> hmm avctx_opts in ffmpeg.c should maybe be split
>>>>
>>>> [...]
>>>>   
>>>>   
>>>>       
>>>>         
>>> one for video, and one for audio ?
>>>     
>>>       
>> yes, we can add one for subtitles later when it becomes needed, there
>> are also many other possible solutions, like writing the options directly
>> into the target context with no avctx_opts in between ...
>>
>>
>>   
>>     
> indeed, i tried to understand how all this option stuff worked, and it
> seems a bit obscure to me for the moment...
> if we want to split audio and video avctx_opts, for instance, we'll have
> to split the "default" handling too, am i right ?
> anyway, i think i'm going to go on reading the source and try to find
> out how this is done...
>
>   
well, i fear i didn't have much time to look at it...
what we have now is:
const char **opt_names=NULL;
int opt_name_count=0;
AVCodecContext *avctx_opts;
AVFormatContext *avformat_opts;

i don't know exactly what is the best to be done...
should we split all those 4 variables ?
should we get rid of avctx_opts ?
in fact, i cannot see how to do it without big changes in ffmpeg.c (at
least)

This was in the first time to make -ab work as -b option, but i guess
it's more than that now, isn't it ?
I'd like to have point of views from you to know what solution is
prefered...

Thanks,
Ben