[Ffmpeg-devel] [PATCH] av_log Doxygen docs

[Panagiotis Issaris]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Michael Niedermayer schreef:
> Hi
> 
> On Mon, Feb 19, 2007 at 07:29:17PM +0100, Panagiotis Issaris wrote:
> [...]
>>>> + * av_log_level. By default, all logging messages are sent to 
>>>> stderr. This
>>>> + * behavior can be altered by setting a different av_vlog callback 
>>>> function.
>>>> + *
>>>> + * @param avcl The AVClass which provides context for the message
>>> No, you pass the address of any structure which has an AVClass* as 
>>> first field. Currently, an AVCodecContext* or AVFormatContext*.
>> Oh, I figured it was a bit OO-inheritance like and had shortened the 
>> following into the above:
>> "The instance of AVClass which provides the context for the message."
>>
>> Do you agree with the unshortened version, or do you think the 
>> shortening was not the problem?
> 
> avc1 is a pointer to a pointer to a AVClass
> 
> or avc1 is a pointer to an arbitrary struct whos first field is a pointer to
> a AVClass struct
> 
> or in OOshit talk avc1 is a pointer to an instance of a subclass of a class
> which contains exactly one field, and this field is a pointer to a AVClass
> instance
> 
> all the same just getting more obfuscated as you get closer to CS dreamland

Here's an updated patch using the imho clearest description (the second).

 log.c |   14 ++++++++++++++
 1 file changed, 14 insertions(+)

With friendly regards,
Takis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF2rlA9kOxLuzz4CkRAvlFAJ4pRC0EyKUIhdBegwe9lUX+DgjdHwCePyuK
/D++KUcJ3ytpYMMtZw2yaeo=
=3Z/7
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20070220T100031-ffmpeg-av_log_dox3.diff
Type: text/x-patch
Size: 966 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070220/653dd979/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20070220T100031-ffmpeg-av_log_dox3.diff.sig
Type: application/octet-stream
Size: 65 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070220/653dd979/attachment.obj>