[Ffmpeg-devel] [PATCH] av_log Doxygen docs

[Panagiotis Issaris]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Michel Bardiaux schreef:
> Panagiotis Issaris wrote:
> [snip]
>>>> Here's an updated patch using the imho clearest description (the
>>>> second).
>>> [...]
>>>> + * Send the specified message to the log if the level is higher
>>>> than or equal to
>>>> + * the current av_log_level. By default, all logging messages are
>>>> sent to
>>> [...]
>>>> + * @param level The importance level of the message, lower values
>>>> signifying
>>>> + * higher importance.
>>> [...]
>>>
>>> lower is more important but level >= av_log_level is sent ? this cant be
>>> correct
>> No, I think level <= av_log_level is sent.
>>
>> libavutil/log.c:
>>     35     if(level>av_log_level)
>>     36         return;
> 
> Aargh, sorry, I gave wrong indications. It is indeed "if the level is
> less than or equal to...".


I'm all confused now :)

To me it seems that ... oh I see now. The remark was about the general
function's explanation not the @param level option...

     31 void av_log_default_callback(void* ptr, int level, ...
     32 {
     33     static int print_prefix=1;
     34     AVClass* avc= ptr ? *(AVClass**)ptr : NULL;
     35     if(level>av_log_level)
     36         return;

I'll send a patch in a second.

With friendly regards,
Takis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF2s9t9kOxLuzz4CkRAkJ4AJ9otDusznKt3sH86LYA4WP4r0LRFACfQW2w
05OPx8I5MIUfurxveNsSBs8=
=mZid
-----END PGP SIGNATURE-----