[Ffmpeg-devel] [PATCH 8/9] Doxygenize av_fast_realloc comments

[Michael Niedermayer]

Hi

On Thu, Feb 22, 2007 at 08:47:58PM +0100, Panagiotis Issaris wrote:
> Hi,
> 
> Michael Niedermayer schreef:
> >On Thu, Feb 22, 2007 at 03:47:06AM +0100, Panagiotis Issaris wrote:
> >  
> >>Hi,
> >>
> >>The attached patch "doxygenizes" the comments for the  av_fast_realloc() 
> >>function.
> >>
> >>avcodec.h |    5 +++--
> >>1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >>With friendly regards,
> >>Takis
> >>
> >>    
> >
> >  
> >>diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> >>index 4962109..14bb53f 100644
> >>--- a/libavcodec/avcodec.h
> >>+++ b/libavcodec/avcodec.h
> >>@@ -2875,7 +2875,9 @@ extern AVBitStreamFilter mjpega_dump_header_bsf;
> >> /* memory */
> >> 
> >> /**
> >>- * realloc which does nothing if the block is large enough
> >>+ * Realloc which does nothing if the block is large enough.
> >>    
> >
> >---
> >Reallocates the given block if it is not large enough, otherwise it
> >does nothing
> >---
> >
> >additionally, this function is a internal function of avcodec
> >and should not be used outside, it shouldnt have a av_ prefix  but ff_
> >and it should be droped if normal av_realloc() is as fast (benchmark a
> >large number of reallocs)
> >  
> I?ll first prepare a patch for moving it and doing the s/av/ff/ thing. 
> Afterwards I'll post
> some benchmarking code so that others correct it and run the benchmark too.

hmm wouldnt it be better to benchmark it first before doing a possibly
redundant move/rename patch?


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070222/ff245601/attachment.pgp>