[Ffmpeg-devel] [PATCH]Update Doxygen comments for libavutil/tree.h

[Dujardin Bernard]

The Wanderer a ?crit :
> Dujardin Bernard wrote:
>
>> Benoit Fouet a ?crit :
>>
>>> Hi,
>>>
>>> Dujardin Bernard wrote:
>>>  
>>>
>>>> Index: tree.h
>>>> ===================================================================
>>>> --- tree.h    (revision 8129)
>>>> +++ tree.h    (working copy)
>>>> @@ -43,10 +50,15 @@
>>>>   *
>>>>   * @return if no insertion happened, the found element
>>>>   *         if a insertion happened, then either key or NULL is 
>>>> returned (which it is
>>>> - *         depends on the tree state and the implemenattion, you 
>>>> should make no
>>>> - *         asumtations that its one or the other in code)
>>>> + *         depends on the tree state and the implementation, you 
>>>> should make no
>>>> + *         assumptions that its one or the other in code)
>>>>   */
>>>>       
>>>
>>> "whether it's" or "whether it is"
>>> and maybe "in the code".
>>
>> Or may be
>> That depends of ...
>
> I don't believe that this usage is valid. I do not recall having ever
> run across it before even as a mistake, much less as a valid
> construction. In any case, I see no need to change this part from the
> existing form; if a change is needed, "which one" or just "which" would
> seem better to me.
>
> Also, as long as we're correcting this: the correct form is "an
> insertion".
>
Needs a grammar expert, I'm not.