[Ffmpeg-devel] [PATCH] Build failes on i386 if snow is disabled

[Diego Biurrun]

On Sun, Feb 25, 2007 at 11:58:05PM +0200, Martin Storsj? wrote:
> On Sun, 25 Feb 2007, Diego Biurrun wrote:
> 
> >On Sun, Feb 25, 2007 at 10:25:45PM +0200, Martin Storsj? wrote:
> >>
> >>Attached is a new attempt at fixing this. It changes all occurrances of
> >>#ifdef CONFIG_SNOW_ENCODER into #if defined(CONFIG_SNOW_ENCODER) ||
> >>defined(CONFIG_SNOW_DECODER), and includes the architecture-dependent dsp
> >>routines in the build only if the snow decoder/encoder is built (the
> >>original problem I had).
> >
> >Doesn't look correct to me, but I think I have fixed it already by
> >changing some CONFIG_SNOW_ENCODERs to CONFIG_SNOW_DECODER.  Let me know
> >if you still have problems.
> 
> This fixes the original problem I had, compiling with everything related 
> to snow disabled.
> 
> However, setting the function pointers to snow-related dsp routines in 
> libavcodec/dsputil.c should be changed to be wrapped in 
> CONFIG_SNOW_DECODER. E.g., if configured with "--disable-encoder=snow 
> --enable-decoder=snow --disable-mmx", the decoder segfaults.

Done, the problem should be gone now.  Report back if you still have
trouble.

Diego