[Ffmpeg-devel] [PATCH] Pass a context to av_log() in libswscale

[Michael Niedermayer]

Hi

On Thu, Jan 04, 2007 at 03:54:51PM +0100, Luca Abeni wrote:
> Hi all,
> 
> the attached patch for libswscale:
> 1) Removes the MSG_* macros, calling av_log() directly as in the other
> libraries
> 2) Introduces a pointer to an AVClass in SwsContext
> 3) Passes the proper SwsContext (when possible) to av_log()
> 
> Is the patch ok, should I split it, or should I change something?

[...]

>  
> -    MSG_WARN("No accelerated colorspace conversion found\n");
> +    av_log(c, AV_LOG_DEBUG, "No accelerated colorspace conversion found\n");

hmm, shuldnt WARN->INFO rather?

maybe we should also consider to increase the number of AV_LOG_* iam not sure
though


besides that, patch is ok assuimig it works with both ffmpeg and mplayer

[...]

> @@ -1991,6 +1997,7 @@
>  	c= av_malloc(sizeof(SwsContext));
>  	memset(c, 0, sizeof(SwsContext));

offtopic but that should be changed to av_mallocz()

[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070104/8c9dfd48/attachment.pgp>