[Ffmpeg-devel] Re: [PATCH/RFC] http seeking

[Michael Niedermayer]

Hi

On Fri, Jan 05, 2007 at 08:14:17AM -0500, Ronald S. Bultje wrote:
> Hi Michael,
> 
> On Fri, 2007-01-05, Michael Niedermayer wrote:
> > On Thu, Jan 04, 2007 at 08:10:33PM -0500, Ronald S. Bultje wrote:
> > > On Fri, 2007-01-05, Michael Niedermayer wrote:
> > > > On Thu, Jan 04, 2007 at 07:24:39PM -0500, Ronald S. Bultje wrote:
> > > > > +static void http_close_cnx(URLContext *h)
> > > > > +{
> > > > > +    HTTPContext *s = h->priv_data;
> > > > > +    url_close(s->hd);
> > > > > +}
> > > > 
> > > > hmm, why not call url_close() everywhere instead? it would also be clearer
> > > > IMHO
> > > 
> > > As opposite of http_open_cnx(). Basically just in case something new
> > > ever gets added that needs to be undone in all places (open and seek)
> > > closing the connection. I can remove it for now if you wish.
> > 
> > i do
> 
> New patch attached.

looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070105/6c1a67e7/attachment.pgp>