[Ffmpeg-devel] [RFC] bytestream show and change

[Alex Beregszaszi]

Hi,

> > This way?
> 
> yes
> 
> though maybe
> 
> #if 1 //benchmark on your architecture and update this #if
> #define AV_RB32(x) ((((uint8_t*)(x))[0] << 24) | \
>                     (((uint8_t*)(x))[1] << 16) | \
>                     (((uint8_t*)(x))[2] << 8) | \
>                      ((uint8_t*)(x))[3])
> #else
> #define AV_RB32(x) le2me_16(LD32(x))
> #endif
> 
> would be better
> 
> also i think that a few more () are needed in the macros

Those macros were there since a while, see the diff, which has the
changes only. Are you fine with the writing logic? Maybe the read part
can be changed to your version in a different commit (optimize reading)

--
Alex Beregszaszi