[Ffmpeg-devel] Bug? Subtitles not detected in vob

[Michael Niedermayer]

Hi

On Mon, Jan 08, 2007 at 08:27:58PM -0000, Wolfram Gloger wrote:
> Hi,
> 
> > I painfully (yeah...) managed to compile this version, and finally
> > succeeded...
> > 
> > result:
> > 
> > Input #0, mpeg, from '/var/tv/test.vob':
> >   Duration: 00:38:59.8, start: 0.060000, bitrate: 18533 kb/s
> >   Stream #0.0[0x1e0]: Video: mpeg2video, yuv420p, 720x576, 8700 kb/s,
> > 25.00 fps(r)
> >   Stream #0.1[0x80]: Audio: ac3, 48000 Hz, 5:1, 384 kb/s
> >   Stream #0.2[0x81]: Audio: ac3, 48000 Hz, 5:1, 384 kb/s
> > Must supply at least one output file
> 
> Arghh, I'm really sorry.  I couldn't believe that to be "fixed"
> by one of my patches, but it is!  To make up for it, I
> painfully managed to isolate which one, and it is the appended
> one, which I have in my tree for years.
> 
> Sorry again for the false data!
> 
> I am therefore re-proposing the appended patch after some years have
> passed :-).

first explain _why_ this change affects the detection of subtitle streams

also this change does 2 things (=should be 2 seperate patches, which fixes
the issue?)
1. it incorrectly sets the start timestamp
2. it returns to the file position where it was before calling this func

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070109/cf167c5d/attachment.pgp>