[Ffmpeg-devel] [PATCH] respect type when resolving MXF strong ref
Reimar Döffinger
Reimar.Doeffinger
Sat Jan 13 19:57:40 CET 2007
Hello,
On Sat, Jan 13, 2007 at 07:45:45PM +0100, Baptiste Coudurier wrote:
> Reimar D?ffinger wrote:
> > On Fri, Jan 12, 2007 at 11:06:06PM +0100, Reimar D?ffinger wrote:
> >> I think this should really be done, since at least in one case we were
> >> even writing into the thing returned by the resolving function without
> >> even checking the type.
> >> Does attached patch look good to you?
> >
> > Update: we discovered that adding AnyType is actually not needed (yet?).
> >
> > Greetings,
> > Reimar D?ffinger
> >
> >
> > [...]
> >
> > for (k = 0; k < mxf->packages_count; k++) {
> > - if (!(temp_package = mxf_resolve_strong_ref(mxf, &mxf->packages_refs[k]))) {
> > + if (!(temp_package = mxf_resolve_strong_ref(mxf, &mxf->packages_refs[k], SourcePackage))) {
> > av_log(mxf->fc, AV_LOG_ERROR, "could not resolve package strong ref\n");
> > - return -1;
> > + continue;
> > }
>
>
>
> remove av_log, else it will be print if MaterialPackage ref is before
> SourcePackage ref, and that's not an error.
Applied, though I also allowed to split in two lines, to make it more
similar to the SourceClip and MaterialPackage cases.
Greetings,
Reimar D?ffinger
More information about the ffmpeg-devel
mailing list