[Ffmpeg-devel] [PATCH] waveformatetensible support

[Baptiste Coudurier]

Michael Niedermayer wrote:
> Hi
> 
> On Sun, Jan 14, 2007 at 01:51:29PM +0100, Baptiste Coudurier wrote:
>> Hi
>>
>> Michael Niedermayer wrote:
>>> Hi
>>>
>>> On Sun, Jan 14, 2007 at 01:39:27AM +0100, Baptiste Coudurier wrote:
>>>> Hi
>>>>
>>>> Here is a patch to support waveformatextensible header.
>>>> Only four first byte of GUID are needed, and they seem to match twocc.
>>> [...]
>>>
>>> cosmetics must be in seperate patches
>>>
>> Ok. Here it is.
> 
> [...]
> 
>> -    codec->codec_id = wav_codec_get_id(id, codec->bits_per_sample);
>> -
>>      if (size > 16) {  /* We're obviously dealing with WAVEFORMATEX */
>> -        codec->extradata_size = get_le16(pb);
>> +        int cbSize = get_le16(pb);
>> +        if (id == 0xfffe) {
>> +            codec->bits_per_sample = get_le16(pb);
>> +            get_le32(pb); /* dwChannelMask */
>> +            id = get_le32(pb); /* 4 first bytes of GUID */
>> +            cbSize = 10; /* skip remaining bytes */
> 
> why? why not read them in extradata?
> 

What would you do with 12 last bytes of GUID in extradata ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312