[Ffmpeg-devel] missing headers?

[Måns Rullgård]

Michael Niedermayer said:
> Hi
>
> On Wed, Jan 17, 2007 at 02:16:01AM +0000, M?ns Rullg?rd wrote:
>> Diego Biurrun <diego at biurrun.de> writes:
>>
>> > On Tue, Jan 09, 2007 at 07:57:51PM +0300, Pavlov Konstantin wrote:
>> >>
>> >> Had some problems recently building SVN version of mplayer with external
>> >> ffmpeg. Looks like mplayer uses some header files which aren't included in
>> >> ffmpeg 'installed' tree.
>> >>
>> >> The attached file fixes those problems.
>> >>
>> >> --- a/libavformat/Makefile
>> >> +++ b/libavformat/Makefile
>> >> @@ -8,7 +8,7 @@ CFLAGS+=-I$(SRC_PATH)/libavcodec
>> >> -HEADERS = avformat.h avio.h rtp.h rtsp.h rtspcodes.h
>> >> +HEADERS = avformat.h avio.h rtp.h rtsp.h rtspcodes.h riff.h
>> >>
>> >> --- a/libavutil/Makefile
>> >> +++ b/libavutil/Makefile
>> >> @@ -18,7 +18,7 @@ OBJS= mathematics.o \
>> >>  HEADERS = avutil.h common.h mathematics.h integer.h rational.h \
>> >> -          intfloat_readwrite.h md5.h adler32.h log.h fifo.h
>> >> +          intfloat_readwrite.h md5.h adler32.h log.h fifo.h bswap.h
>> >
>> > What about this?
>>
>> Rejected.  Those headers are internal to ffmpeg.  Apps have no
>> business poking with them, not even mplayer.
>
> libavutil is not just a internal part of libav* so bswap.h must be installed
> maybe with different name maybe with renamed functions but it must be installed

They must be renamed, internal or not.  If they are to be part of the public
API, they should all have av_ prefixes.

> about riff.h, the fourcc<->codec id tables and corresponding utility functions
> should be in a installed header

Then they should also be renamed.  They could use a bit of cleaning too.

-- 
M?ns Rullg?rd
mru at inprovide.com