[Ffmpeg-devel] h.264 decoder segfault

[Benoit Fouet]

Michael Niedermayer wrote:
> Hi
>
> On Wed, Jan 24, 2007 at 12:45:21AM +0100, Diego Biurrun wrote:
>   
>> On Tue, Jan 23, 2007 at 07:47:42PM +0100, Benoit Fouet wrote:
>>     
>>> Reimar D?ffinger wrote:
>>>       
>>>>> --- libavcodec/h264.c   (revision 7661)
>>>>> +++ libavcodec/h264.c   (working copy)
>>>>> @@ -26,6 +26,8 @@
>>>>>
>>>>> +#undef ARCH_X86
>>>>> +#undef HAVE_MMX
>>>>>  #include "common.h"
>>>>>  #include "dsputil.h"
>>>>>  #include "avcodec.h"
>>>>>     
>>>>>           
>>>> Um.. I don't think those #undefs have any point if they are before
>>>> #include "common.h"...
>>>>   
>>>>         
>>> due to my lack of knowledge on ffmpeg, i put them at the very beginning
>>> of the file :)
>>> what should have i done to do it properly ?
>>>       
>> Put them after all includes.
>>     
>
> especially after the ones which contain static inline functions with asm ;)
>   
ok i seeit now.
Was because of me not even opening the include files before adding the
undefs :-[

thanks,

Ben