[Ffmpeg-devel] [PATCH] Dead code cleanup - C++

[Ulrich von Zadow]

Ramiro Polla wrote:
> Ulrich von Zadow wrote:
>> The lines that are removed
>> by the patch would need to be inserted into every c++ program using
>> libav*. 
> And every MSVC system needs to add inttypes.h and stdint.h.

The point is that right now, it's a few lines of code in one library.
After the change, these lines of code will have to be duplicated in lots
of libraries. IMHO, duplicated code is bad - it's a waste of programmer
time.

> It doesn't provide an API for C#, Fortran, Pascal, Java, or
> even C89.
> C++ should be no exception.

C#, Fortran, Pascal and Java would require a major effort for support.
C++ requires these few lines. Please don't willfully make life harder
for C++ programmers.

Re: Consistency: Yes, adding the appropriate lines to other public
headers would make sense. It wouldn't even need a version bump :-).

Regards,

  Uli