[Ffmpeg-devel] [PATCH] inet_aton

[Michael Niedermayer]

Hi

On Wed, Jan 24, 2007 at 05:16:06PM -0200, ramiro at lisha.ufsc.br wrote:
> Hello,
> 
> The current inet_aton implementation in os_support.c returns valid even if
> a string (the hostname) has been passed.
> 
> Fran?ois, does it work for you when passing a hostname instead of an IP
> address to FFmpeg?
> 
> Does BeOS have the inet_addr function? If so we could use Michael Kohn's
> implementation of inet_aton as a wrapper around inet_addr.
> 
> Attached patch takes inet_aton from uClibc (which is also LGPL).

what problem does this patch solve?

also the new code looks more complex then the old this is enough for
rejection unless you proof that this complexity is needed to solve the
problem

and the htonl() should rather be be2me_32()



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070128/b77fbfc7/attachment.pgp>