[Ffmpeg-devel] [PATCH] inet_aton

[François Revol]

> Hi
> 
> On Wed, Jan 24, 2007 at 05:16:06PM -0200, ramiro at lisha.ufsc.br wrote:
> > Hello,
> > 
> > The current inet_aton implementation in os_support.c returns valid even if
> > a string (the hostname) has been passed.
> > 
> > Fran?ois, does it work for you when passing a hostname instead of an IP
> > address to FFmpeg?
> > 
> > Does BeOS have the inet_addr function? If so we could use Michael Kohn's
> > implementation of inet_aton as a wrapper around inet_addr.
> > 
> > Attached patch takes inet_aton from uClibc (which is also LGPL).
> 
> what problem does this patch solve?
> 
> also the new code looks more complex then the old this is enough for
> rejection unless you proof that this complexity is needed to solve the
> problem
> 


As I said, changing the gotos to return 1 (or whatever error) should fix the most obvious.

Fran?ois.