[Ffmpeg-devel] [PATCH] fix for libavcodec/armv4l/mpegvideo_armv5te.c

[Siarhei Siamashka]

On 1/29/07, Dmitry Antipov <dmantipov at yandex.ru> wrote:

f> > Thanks for reporting this. Surely add and sub instructions on ARM have
> > 3 operands, but both gcc 3.4.4 and gcc 4.1.1 that I have tested,
> > accepted this code without any problems (maybe it is some kind of
> > syntax sugar?). Did this code break on your compiler? What version of
> > gcc do you have?
>
> I'm using (cross) gcc 3.4.3. Here is a failure report with gcc 4.0.2:
> http://lists.mplayerhq.hu/pipermail/mplayer-users/2007-January/065126.html
> (note this user probably has poorly configured compiler, btw.)

Thanks a lot. I'll try to experiment with my compiler today in the
evening and will try to make it behave more strict in order to detect
and avoid such problems in the future. The patch itself looks OK.

It is good to know that many people actually test mplayer/ffmpeg on
ARM. I did test this code myself, and also some other people tried it
too, but appears there is always a chance for some unexpected problem
to remain unnoticed. Apart from syntax issues, this code should work
fine and it is used in mplayer build for nokia 770 for a few weeks
already (with hundreds of downloads) without any bugs reported. Also
it is covered by some extra regression tests.