[FFmpeg-devel] [PATCH] VC-1 MMX DSP functions

Reimar Döffinger Reimar.Doeffinger
Sat Jul 7 16:37:37 CEST 2007


Hello,
On Sat, Jul 07, 2007 at 09:21:43PM +0800, Zuxy Meng wrote:
> 2007/7/7, Christophe GISQUET <christophe.gisquet at free.fr>:
> > infernix a ?crit :
> > > This breaks compilation on Debian Etch x86_64. I'm unsure if this is
> > > expected behavior though.
> >
> > I have no 64bits machine to test it on, so your reports are welcome.
> >
> > > /tmp/ccaopxZe.s:25763: Error: `0(%rdx,%ecx)' is not a valid base/index
> > > expression
> >
> > int where long int should be used. This probably was in the first patch,
> > but I forgot to reinsert a cast when refactoring vc1dsp_mmx.c.
> 
> long only works for LP64; intptr_t is safer.

I think we currently support more systems without intptr_t than non-LP64 systems
so I don't think this is a good suggestion.

Greetings,
Reimar D?ffinger




More information about the ffmpeg-devel mailing list