[FFmpeg-devel] Making FFmpeg C99 again. Take II.

[Roman Shaposhnik]

Hi

On Sat, 2007-07-07 at 23:37 +0200, Michael Niedermayer wrote:
> please use 
> } else if ... { 
> like the rest of te file and libav*
  
  Sure. To reiterate: it would be awfully nice to have things
like this one formally recorded in our docs. libav* uses all
sorts of styles and usually doesn't help much determining 
the style to use (although your point about internal file
consistency is definitely a valid one).

> > -        break;
> > -    case 0x10003001:
> > +    }
> > +    else if (avctx->sub_id == 0x10003001) {
> >          s->rv10_version= 3;
> > +    }
> > +    else if (    avctx->sub_id == 0x20001000
> > +             || (avctx->sub_id >= 0x20100000 && avctx->sub_id < 0x201a0000)) {
> >          s->low_delay=1;
> 
> this does not look correct, low_delay=1 seems to get lost 

  Which one? I specifically tried to edit the file in a way that would
leave actual assignments intact. The only exception is this one and 
I think it is a faithful representation of the original code. Here's
how original code looks like:

    case 0x20001000: /* real rv20 decoder fail on this id */
    /*case 0x20100001:
    case 0x20101001:
    case 0x20103001:*/
    case 0x20100000 ... 0x2019ffff:
        s->low_delay=1;
        break;

and here's the new code:

    else if (    avctx->sub_id == 0x20001000
             || (avctx->sub_id >= 0x20100000 && avctx->sub_id < 0x201a0000)) {
        s->low_delay=1;
    }

  Am I missing something here?

Thanks,
Roman.