[FFmpeg-devel] [PATCH] split png.c

[Diego Biurrun]

On Tue, Jul 17, 2007 at 02:16:12PM +0200, Baptiste Coudurier wrote:
> 
> Attila Kinali wrote:
> > On Sun, 15 Jul 2007 17:12:46 +0100
> > M?ns Rullg?rd <mans at mansr.com> wrote:
> > 
> >> I'd like to apply this.  Objections?
> > 
> > Would it be possible to call the header file lavc_png.h or 
> > something similar? png.h clashes with the global header file
> > of libpng which is placed in /usr/include. This already caused
> > compile problems in MPlayer[1] and i'm sure it will cause problems
> > for other projects too.
> 
> Sorry but Im against this, png.h is internal header and is not meant to
> be included from any project directly. IMHO Mplayer is faulty here.

It isn't.  The build system just looked in libavcodec/ before looking in
/usr/include.

> > [...]
> > 
> > [1] Yes M?ns, you broke MPlayer again ;-)
> 
> Expect Mplayer to be broken oftenly if it keeps using internal ffmpeg
> structures, and not officially exported ones.

Blame Michael ;-p

Diego