[FFmpeg-devel] [PATCH] emulated inet_aton doesn't fail for invalid addresses

[Michael Niedermayer]

Hi

On Mon, Jul 16, 2007 at 09:37:39PM +0200, elupus wrote:
> Hi,
> 
> Here is a new try. Never though of that nice bitwise simplification. Nice 
> thou.

patch ok

[...]
>      add1 = atoi(pch);
>      pch = strpbrk(pch,".");
> -    if (pch == 0 || ++pch == 0) goto done;
> +    if (pch == 0 || ++pch == 0) return 0;

while unrelated ... 
the ++pch == 0 makes no sense, it can never be true

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070717/dd8414b0/attachment.pgp>