[FFmpeg-devel] [PATCH] Return ENOTSUP if codec does not support feature

[Michael Niedermayer]

Hi

On Fri, Jul 20, 2007 at 03:32:36PM +0200, Panagiotis Issaris wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi,
> 
> Return AVERROR(ENOTSUP) in case the used codec does not support the
> requested feature.

[...]
> @@ -362,43 +362,43 @@
>      if((s->flags & CODEC_FLAG_4MV) && s->codec_id != CODEC_ID_MPEG4
>         && s->codec_id != CODEC_ID_H263 && s->codec_id != CODEC_ID_H263P && s->codec_id != CODEC_ID_FLV1){
>          av_log(avctx, AV_LOG_ERROR, "4MV not supported by codec\n");
> -        return -1;
> +        return AVERROR(ENOTSUP);
>      }

this is incorrect, the combination is invalid not just not supported
the same is true for several others


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070720/dbe5700a/attachment.pgp>