[FFmpeg-devel] [PATCH] cleanup swscale

[Michael Niedermayer]

Hi

On Wed, Jun 06, 2007 at 12:06:32AM +0200, Luca Barbato wrote:
> here a first patch that makes swscale less ugly, the next steps will be
> making a template file for x86 by svn cp and make the scalar template C
> only.
> 
>  swscale.h          |   35 +++++----
>  swscale_template.c |  205
> ++++++++++++++++++++++++++++++++++-------------------
>  2 files changed, 158 insertions(+), 82 deletions(-)

[...]

> Index: libswscale/swscale.h
> ===================================================================
> --- libswscale/swscale.h	(revision 23482)
> +++ libswscale/swscale.h	(working copy)
> @@ -103,19 +103,30 @@
>  
>  void sws_freeContext(struct SwsContext *swsContext);
>  
> -struct SwsContext *sws_getContext(int srcW, int srcH, int srcFormat, int dstW, int dstH, int dstFormat, int flags,
> -                                  SwsFilter *srcFilter, SwsFilter *dstFilter, double *param);
> -int sws_scale(struct SwsContext *context, uint8_t* src[], int srcStride[], int srcSliceY,
> -              int srcSliceH, uint8_t* dst[], int dstStride[]);
> -int sws_scale_ordered(struct SwsContext *context, uint8_t* src[], int srcStride[], int srcSliceY,
> -                      int srcSliceH, uint8_t* dst[], int dstStride[]) attribute_deprecated;
> +struct SwsContext *sws_getContext(int srcW, int srcH, int srcFormat, int dstW,
> +                                  int dstH, int dstFormat, int flags,
> +                                  SwsFilter *srcFilter, SwsFilter *dstFilter,
> +                                  double *param);

please try to group similar parameters under each other if you already 
reformat the code:

struct SwsContext *sws_getContext(int srcW, int srcH, int srcFormat,
                                  int dstW, int dstH, int dstFormat, int flags,
                                  SwsFilter *srcFilter,
                                  SwsFilter *dstFilter, double *param);


>  
> +int sws_scale(struct SwsContext *context, uint8_t* src[], int srcStride[],
> +              int srcSliceY, int srcSliceH, uint8_t* dst[], int dstStride[]);

int sws_scale(struct SwsContext *context,   uint8_t* src[], int srcStride[],
              int srcSliceY, int srcSliceH, uint8_t* dst[], int dstStride[]);

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070606/c26a3974/attachment.pgp>