[FFmpeg-devel] [RFC] move wmv2.c to its own file

[Kostya]

On Thu, Jun 07, 2007 at 10:35:43PM +0200, Michael Niedermayer wrote:
> Hi
> 
> On Thu, Jun 07, 2007 at 09:33:23PM +0200, Denis Fortin wrote:
> > 
> > >>> Attached is a patch which moves code_012 to ff_code012 (and nothing 
> > >>> else). It's just a reminder for Diego's patch and i don't expect to see 
> > >>> mine applied.

[...]

> -> you cannot use a inline void ff_msmpeg4_encode_block() from another
> source/object file
> it works with gcc only because gcc does not implement inline correctly
> in gcc "inline" is some sort of randomly ignoreable keyword
> 
> also simply removing inline would require some benchmarks ...

Maybe do with it as with code012 reading function - move it to bitstream.h?
Thus it is possible to use it from anywhere while preserving inline.
Just a thought.

> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> I am the wisest man alive, for I know one thing, and that is that I know
> nothing. -- Socrates