[FFmpeg-devel] [PATCH] cleanup swscale

[Baptiste Coudurier]

Hi

Luca Barbato wrote:
> Michael Niedermayer wrote:
>>> -static inline void yuv2yuvXinC(int16_t *lumFilter, int16_t **lumSrc, int lumFilterSize,
>>> -                               int16_t *chrFilter, int16_t **chrSrc, int chrFilterSize,
>>> -                               uint8_t *dest, uint8_t *uDest, uint8_t *vDest, int dstW, int chrDstW)
>>> +static inline void yuv2yuvXinC(int16_t *lumFilter,
>>> +                               int16_t **lumSrc, int lumFilterSize,
>>> +                               int16_t *chrFilter,
>>> +                               int16_t **chrSrc, int chrFilterSize,
>>> +                               uint8_t *dest,
>>> +                               uint8_t *uDest, uint8_t *vDest,
>>> +                               int dstW, int chrDstW)
>> this is less readable not more than the original code
> 
> people using 80col will find the latter more readable.

see below.

>> same here
> 
> Idem
>>
>> [...]
>>>  
>>> -static inline void yuv2packedXinC(SwsContext *c, int16_t *lumFilter, int16_t **lumSrc, int lumFilterSize,
>>> -                                  int16_t *chrFilter, int16_t **chrSrc, int chrFilterSize,
>>> +static inline void yuv2packedXinC(SwsContext *c,
>>> +                                  int16_t *lumFilter,
>>> +                                  int16_t **lumSrc, int lumFilterSize,
>>> +                                  int16_t *chrFilter,
>>> +                                  int16_t **chrSrc, int chrFilterSize,
>> static inline void yuv2packedXinC(SwsContext *c, 
>>                                   int16_t *lumFilter, int16_t **lumSrc, int lumFilterSize,
>>                                   int16_t *chrFilter, int16_t **chrSrc, int chrFilterSize,
>>
> 
> not 80cols safe

I find Michael's way of formating really more readable than the solution 
< 80 cols.

I also find having "static inline void func_name" more readable than
"static inline void"
"func_name"

I think we shouldn't break lines to fit 80 cols just for the sake of 
having lines < 80 cols, but for real reasons.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312