[FFmpeg-devel] [PATCH] Move the video size and rate abbreviations system from libavformat to libavcodec

[Stefano Sabatini]

On date Saturday 2007-06-09 10:36:30 +0200, Diego Biurrun encoded:
> On Sat, Jun 09, 2007 at 08:58:52AM +0200, Stefano Sabatini wrote:
> > On date Thursday 2007-06-07 15:11:15 +0200, Stefano Sabatini encoded:
> > > Suggested changelog message:
> > > "Moves the parse_image_size and parse_frame_rate functionality from
> > > libavformat to libavcodec, deprecates parse_image_size and
> > > parse_frame_rate in favour of av_parse_image_size and
> > > av_parse_frame_rate."
> > > 
> > > Just another nitpick: I'd prefer to call parse_image_size and
> > > parse_frame_rate in this way:
> > > 
> > > parse_image_size -> av_parse_video_frame_size
> > > parse_frame_rate -> av_parse_video_frame_rate
> > > 
> > > for both symmetry and unambiguity ("frame" may refer to both a video or
> > > an audio frame). If you like this I can provide another patch with the
> > > corresponding changes.
> > 
> > Here it is.
> 
> .. some spelling nitpicks ..
> 
> > --- libavcodec/utils.c	(revision 9235)
> > +++ libavcodec/utils.c	(working copy)
> > @@ -1347,3 +1347,113 @@
> > +
> > +static AbvEntry frame_abvs[] = {
> > +    { "ntsc",      720, 480, 30000, 1001 },
> > +    { "pal",       720, 576,    25,    1 },
> > +    { "qntsc",     352, 240, 30000, 1001 }, /* VCD compliant ntsc */
> > +    { "qpal",      352, 288,    25,    1 }, /* VCD compliant pal */
> > +    { "sntsc",     640, 480, 30000, 1001 }, /* square pixel ntsc */
> > +    { "spal",      768, 576,    25,    1 }, /* square pixel pal */
> 
> NTSC, PAL

Fixed.

> > --- libavcodec/avcodec.h	(revision 9235)
> > +++ libavcodec/avcodec.h	(working copy)
> > @@ -3143,6 +3143,32 @@
> >  
> >  extern unsigned int av_xiphlacing(unsigned char *s, unsigned int v);
> >  
> > +/**
> > + * Parses \p str and put in \p width_ptr and \p height_ptr the detected values.
> > + *
> > + * @return 0 in case of a succesfull parsing, -1 otherwise
> 
> succesSfuL

Fixed.
 
> > + * @param[in] str the string to parse: it has to be a string in the format
> > + * <width>x<height> or a valid video frame size abbreviation.
> > + * @param[in,out] width_ptr pointer to the variable which will contain the detected
> > + * frame width value
> > + * @param[in,out] height_ptr pointer to the varaible which will contain the detected
> 
> varIAble
> 
> > + * @return 0 in case of a succesfull parsing, -1 otherwise
> 
> dito

Fixed. 

Cheers
-- 
Stefano Sabatini
Linux user number 337176 (see http://counter.li.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: move-video-abbrs-support-to-libavcodec-04.patch
Type: text/x-diff
Size: 10661 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070609/25282372/attachment.patch>