[FFmpeg-devel] [PATCH] Bugfix: decoding 8- and 24-bit FLAC files

[Måns Rullgård]

Benoit Fouet wrote:
> Hi,
>
> Michael Donaghy wrote:
>> Index: libavcodec/flac.c
>> ===================================================================
>> --- libavcodec/flac.c	(revision 9283)
>> +++ libavcodec/flac.c	(working copy)
>> @@ -684,8 +673,8 @@
>>              {\
>>                  int a= s->decoded[0][i];\
>>                  int b= s->decoded[1][i];\
>> -                *(samples++) = (left ) >> (16 - s->bps);\
>> -                *(samples++) = (right) >> (16 - s->bps);\
>> +                *(samples++) = (left  << (24 - s->bps)) >> 8;\
>> +                *(samples++) = (right << (24 - s->bps)) >> 8;\
>>
>
> i think this code lacks paretheses

I think it has too many.

-- 
M?ns Rullg?rd
mans at mansr.com