[FFmpeg-devel] [PATCH] imlib2's rgb.txt

[Ramiro Polla]

Michael Niedermayer wrote:
> Hi
>
> On Mon, Jun 18, 2007 at 02:13:12PM -0300, Ramiro Ribeiro Polla wrote:
>   
>> Michael Niedermayer wrote:
>>     
>>> Hi
>>>
>>> On Sat, Jun 16, 2007 at 09:40:46PM -0300, Ramiro Ribeiro Polla wrote:
>>> [...]
>>>  
>>>       
>>>>>>> This is interesting. Used with output_example's video, you get quite a
>>>>>>> psychedelic output =).
>>>>>>> Patch attached (and then another commit to reindent).
>>>>>>>     
>>>>>>>          
>>>>>>>               
>>>>>> While you're on it, what about adding the alpha channel too (R,G,B,A)?
>>>>>> -A max(255,N) would produce a nice fade in text.
>>>>>>   
>>>>>>        
>>>>>>             
>>>>> Oops, I really mean -A min(255,N)
>>>>>
>>>>>      
>>>>>           
>>>> Patch attached =)
>>>>    
>>>>         
>>> [...]
>>>  
>>>       
>>>> @@ -333,9 +338,18 @@
>>>>         }
>>>>     }
>>>>
>>>> -    if (!ci->eval_colors)
>>>> -        imlib_context_set_color(ci->r, ci->g, ci->b, 255);
>>>> +    if (ci->expr_A) {
>>>> +        if (!(ci->eval_a = ff_parse(ci->expr_A, const_names, NULL, NULL, 
>>>> NULL, NULL, NULL))){
>>>> +        av_log(NULL, AV_LOG_ERROR, "Couldn't parse A expression '%s'\n", 
>>>> ci->expr_A);
>>>> +        return -1;
>>>> +        }
>>>>    
>>>>         
>>> indention
>>>
>>>
>>>  
>>>       
>> Fixed, and also fixed the freeing of expr_ and eval_ following Limin 
>> Wang's patch.
>>     
>
> looks ok
>
>   

Applied.