[FFmpeg-devel] dv_read_seek over 2GB fix

Michael Niedermayer michaelni
Tue Jun 19 02:33:32 CEST 2007


Hi

On Mon, Jun 18, 2007 at 07:03:41PM +0300, Maksym Veremeyenko wrote:
> Michael Niedermayer ?????:
> 
> >
> >offset_t url_fseek(ByteIOContext *s, offset_t offset, int whence)
> >{
> >[...]
> >        return AVERROR(EINVAL);
> >[...]
> >        offset_t res = AVERROR(EPIPE);
> >
> >
> >>this value re-returned to av_seek_frame that 
> >>do not care about error code - it's interesting only in sign of returned 
> >>value from:
> >
> >its not relevant if any current code checks for specific errors or just
> >error vs. no error, the code should properly pass error codes
> this version of attached patch returns 0 on success or negative error code.

looks ok (minus the trailing whitespace) but iam not dv maintainer,
roman is that ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070619/d07f3b56/attachment.pgp>



More information about the ffmpeg-devel mailing list