[FFmpeg-devel] dv_read_seek over 2GB fix

[Michael Niedermayer]

Hi

On Tue, Jun 19, 2007 at 02:02:35PM -0700, Roman Shaposhnik wrote:
> On Tue, 2007-06-19 at 15:08 +0300, Maksym Veremeyenko wrote:
> > >> looks ok (minus the trailing whitespace) but iam not dv maintainer,
> > >> roman is that ...
> > Trailing spaces removed. cleaned patch version attached.
> > 
> > >   Isn't the bigger issue here that AVInputFormat::read_seek() has a
> > > return type that doesn't make much sense with the lfcompile(5) ?

No manual entry for lfcompile
and changing the return value would need a major version bump


> > problem is in "truncating" returned value...
> > 
> > Is this patch OK? Could you commit this one?
> 
>   I still have the same question (I guess Michael should be the one
> to really answer it): what is the semantics of the
> AVInputFormat::read_seek() return value (and perhaps we should even
> include the description of the semantics into the avformat.h).

<0 is error, ideally a proper error code
>=0 is no error

the meaning of the individual >=0 is unspecified currently, that might
change though

what does matter is that if no error happens then the return should be
>= 0

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070620/bcb89796/attachment.pgp>