[FFmpeg-devel] [PATCH] move fast dct and trellis quantize function pointers initialization

[Michael Niedermayer]

Hi

On Wed, Jun 20, 2007 at 10:23:37AM +0200, Benoit Fouet wrote:
> Benoit Fouet wrote:
> > Michael Niedermayer wrote:
> >   
> >> Hi
> >>
> >> On Wed, Jun 20, 2007 at 08:38:06AM +0100, M?ns Rullg?rd wrote:
> >>   
> >>     
> >>> Benoit Fouet <benoit.fouet at purplelabs.com> writes:
> >>>
> >>>     
> >>>       
> >>>> Hi,
> >>>>
> >>>> the patch moves the encoder specific part of DCT_common_init under the
> >>>> same ifdef.
> >>>> it also removes the comment telling to do so :)
> >>>>       
> >>>>         
> >>> OK with me.
> >>>     
> >>>       
> >> approving pacthes for code maintained by others? didnt you just complain
> >> about me approving one for configure?
> >>
> >> anyway i dont mind it if you do, actually iam happy if people help 
> >> reviewing and approving stuff but here the patch is not ok at all
> >>
> >> the 
> >> s->fast_dct_quantize= s->dct_quantize;
> >> is currently done after dct_quantize is set up (possibly to a mmx optimized
> >> variant) but after the patch its just set to the c variant ...
> >>
> >> [...]
> >>   
> >>     
> >
> > i can move the CONFIG_ENCODERS part after the arch dependant
> > MPV_common_init_*
> > would that be ok ?
> >
> >   
> 
> and patch attached to make it easier to see...

looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070620/298e1d4d/attachment.pgp>