[FFmpeg-devel] [PATCH] File concat protocol

[Wolfram Gloger]

Hi,

> this should be in a seperate file not in file.c

Ok.

> also it should not be specific to the file protocol but rather work
> with all, its kinda silly if we next add a httpconcat then a filehttpconcat
> ..

Ok, I can't really see much point in a non-file concat, but since it
was rather easy to implement, I did it.

> no doxygen comment

Added.

> > +#if defined(__MINGW32__) || defined(CONFIG_OS2) || defined(__CYGWIN__)
> > +    access |=3D O_BINARY;
> > +#endif
> 
> this is duplicated relative to existing code from file.c

As a nice side effect, this goes away when using url rather than file..

> i think such ifdef hell should not be accepted in new patches
> configure or some other appropriate thing should check availability of
> _fstat64/stat and provide a working stat() or set HAVE__STAT64 or whatever

Same for this.

Regards,
Wolfram
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/octet-stream
Size: 6267 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070624/4631aea2/attachment.obj>