[FFmpeg-devel] ffmpeg.c/cmdutils.c compilation
Michael Niedermayer
michaelni
Sun Jun 24 17:59:28 CEST 2007
Hi
On Sun, Jun 24, 2007 at 11:23:10AM -0400, Ronald S. Bultje wrote:
> Hi,
>
> On 6/22/07, Michael Niedermayer <michaelni at gmx.at> wrote:
> >
> > On Fri, Jun 22, 2007 at 09:15:30PM -0400, Ronald S. Bultje wrote:
> > > recent changes don't allow those to be compiled w/o HAVE_AV_CONFIG_H
> > > anymore. Attached patch fixes half of it, although av_abort() and
> > > closesocket() need some dirt. Should I no longer try to do them w/o
> > > HAVE_AV_CONFIG_H? That's bad, since they're examples for applications,
> > and
> > > other applications would need to do w/o HAVE_AV_CONFIG_H also.
> >
> > HAVE_AV_CONFIG_H should not be set when compiling examples, someone should
> > change svn if needed so HAVE_AV_CONFIG_H isnt set for examples ...
>
>
> So what's the preferred way of doing this?
>
> - change source code to not use internal av_*() functions (e.g. av_abort())
> which are protected by HAVE_AV_CONFIG_H, but use system functions (e.g.
> abort()) instead
> - unprotect any such functions and allow applications to use them
>
> I can send a patch either way, but would prefer to not have to do it
> twice...
s/av_abort/abort/ in these test/example applications
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070624/f6e22af5/attachment.pgp>
More information about the ffmpeg-devel
mailing list