[FFmpeg-devel] [PATCH] File concat protocol

[Alex Beregszaszi]

Hi,

> >> >> +        if (len == 0)
> >> >> +            break;
> >> >> +        fn = av_malloc(len+1);
> >> >> +        strncpy(fn, filename, len);
> >> >
> >> > shouldnt av_strlcpy() be used here?
> >> 
> >> strncpy() certainly won't do the right thing (it rarely does).
> >> av_strlcpy(fn, filename, len+1) should work, even though it's not the
> >> typical use case.
> >
> > Why not av_strdup ?
> 
> Because it does something else.

What else?

> >> >> +        fn = av_malloc(len+1);
> >> >> +        strncpy(fn, filename, len);

--
Alex