[FFmpeg-devel] [PATCH] RoQ Cosmetics - 1

[Vitor]

Hi

Michael Niedermayer wrote:
> Hi
> 
> [...]
>> @@ -109,10 +112,13 @@
>>          return;
>>      }
>>  
>> -    for(cp = 0; cp < 3; cp++)
>> -        block_copy(ri->current_frame->data[cp] + (y * ri->y_stride) + x,
>> -                   ri->last_frame->data[cp] + (my * ri->y_stride) + mx,
>> -                   ri->y_stride, ri->y_stride, sz);
>> +    for(cp = 0; cp < 3; cp++) {
>> +        stride = cp==0 ? ri->y_stride : ri->c_stride;
> 
> ri->current_frame.linesize[cp] seems like the more natural solution

I agree, patch attached.

> 
>> +        block_copy(ri->current_frame->data[cp] + (y*stride) + x,
>> +                   ri->last_frame->data[cp] + (my*stride) + mx,
> 
> superfluos () but removing that belongs to a seperate change theoretically
> 
> and iam in favor of giving you a svn write account
> if there are no objections and you agree to our svn/development policy
> then send diego a username&password

Thanks. I agree with the svn/development policy. Btw, I've just reread 
the coding rules part, and I think it would be nice to have a mention 
about useless casts and ()'s. I'll try to write a small paragraph and 
send a patch to the list.

-Vitor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: stride2.diff
Type: text/x-patch
Size: 1387 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070627/c53ce246/attachment.bin>