[Ffmpeg-devel] Stack overflow patch

Måns Rullgård mans
Fri Mar 2 19:09:40 CET 2007


Kristian Amlie <kristian at gridmedia.com> writes:

> Quoting M?ns Rullg?rd <mans at mansr.com>:
>
>> Kristian Amlie <kristian at gridmedia.com> writes:
>>
>>> This patch fixes ffmpeg so that av_find_stream_info() can be called
>>> from MSVC++ without causing a stack overflow. It does so by replacing
>>> the auto array "duration_error" with a malloced array.
>>
>> What difference does it make which compiler is used for the calling code?
>
> The stack size is smaller on Windows by default.

Doesn't it automatically grow as needed until memory runs out, as it
does on Unix-type OSes?

> It is possible to change it, but there is no reason why ffmpeg
> shouldn't work out of the box (plus the code already had a FIXME in
> that location).

I'm not opposing the change.  I was only curious why it's needed.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list