[Ffmpeg-devel] [PATCH] Move libavformat Doxygen and other comments to avformat.h
Panagiotis Issaris
takis
Sat Mar 3 22:48:07 CET 2007
Hi,
Panagiotis Issaris schreef:
> Panagiotis Issaris schreef:
>> Michael Niedermayer schreef:
>>> On Thu, Mar 01, 2007 at 05:12:46PM +0100, Panagiotis Issaris wrote:
>>>>
>>> [...]
>>>
>>>> +/**
>>>> + * Print nice hexa dump of a buffer
>>>> + * @param f stream for output
>>>> + * @param buf buffer
>>>> + * @param size buffer size
>>>> + */
>>>> void av_hex_dump(FILE *f, uint8_t *buf, int size);
>>>> +
>>>> +/**
>>>> + * Print on 'f' a nice dump of a packet
>>>> + * @param f stream for output
>>>> + * @param pkt packet to dump
>>>> + * @param dump_payload true if the payload must be displayed too
>>>> + */
>>>> void av_pkt_dump(FILE *f, AVPacket *pkt, int dump_payload);
>>>>
>>>
>>> these should be changed to av_logish style, (FILE dependancy sucks ...)
>>> thats of course seperate and independant of this patch
>>>
>> OK, I'll write a patch for this later today.
> Oh, and furthermore, should I give the new av_(pkt|hex)_dump new
> names? Or how should the API change be handled?
>
>
> av_hex_dump_log & av_pkt_dump_log
> av_hex_log & av_pkt_log
> av_hex_dump2 & av_pkt_dump2
The attached patch is *not* meant for SVN inclusion as it *breaks* the
ABI. It's just a first version I'm posting while awaiting a reply
regarding the question asked above and the one regarding the level
parameter: Currently it assumes all av_*_dumps should be logged as
AV_LOG_DEBUG.
ffmpeg.c | 2 +-
ffserver.c | 2 +-
libavformat/avformat.h | 4 ++--
libavformat/mpegts.c | 10 +++++-----
libavformat/utils.c | 40 ++++++++++++++++++++--------------------
5 files changed, 29 insertions(+), 29 deletions(-)
With friendly regards,
Takis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20070303T224355-ffmpeg-loggish_dump.diff
Type: text/x-patch
Size: 6867 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070303/0bdc3d31/attachment.bin>
More information about the ffmpeg-devel
mailing list