[Ffmpeg-devel] [PATCH] Move libavformat Doxygen and other comments to avformat.h

[Panagiotis Issaris]

Panagiotis Issaris schreef:
> Michael Niedermayer schreef:
>> On Sat, Mar 03, 2007 at 09:25:32PM +0100, Panagiotis Issaris wrote:
>>  
>>> Panagiotis Issaris schreef:
>>>    
>>>> Hi,
>>>>
>>>> Michael Niedermayer schreef:
>>>>      
>>>>> On Thu, Mar 01, 2007 at 05:12:46PM +0100, Panagiotis Issaris wrote:
>>>>>
>>>>>        
>>>>>> +/**
>>>>>> + * Print  nice hexa dump of a buffer
>>>>>> + * @param f stream for output
>>>>>> + * @param buf buffer
>>>>>> + * @param size buffer size
>>>>>> + */
>>>>>> void av_hex_dump(FILE *f, uint8_t *buf, int size);
>>>>>> +
>>>>>> +/**
>>>>>> + * Print on 'f' a nice dump of a packet
>>>>>> + * @param f stream for output
>>>>>> + * @param pkt packet to dump
>>>>>> + * @param dump_payload true if the payload must be displayed too
>>>>>> + */
>>>>>> void av_pkt_dump(FILE *f, AVPacket *pkt, int dump_payload);
>>>>>>              
>>>>> these should be changed to av_logish style, (FILE dependancy sucks 
>>>>> ...)
>>>>> thats of course seperate and independant of this patch
>>>>>  
>>>>>         
>>>> OK, I'll write a patch for this later today.
>>>>       
>>> Do you prefer to be able to specify the level as a av_(hex|pkt)_dump 
>>> parameter, or should AV_LOG_DEBUG be implied?
>>>     
>>
>> id like to be able to specify the level
>>   
> Okay, I'll change that as soon as my other question regarding the 
> patch is answered. 
The attached patch is *not* meant for SVN inclusion as it *breaks* the 
ABI. It's just a first version I'm posting while awaiting a reply 
regarding the way to keep the old av_hex|pkt_dump API available until 
the next major version bump. The level is not implied anymore.

 ffmpeg.c               |    2 +-
 ffserver.c             |    2 +-
 libavformat/avformat.h |   20 ++++++++++++++------
 libavformat/mpegts.c   |   10 +++++-----
 libavformat/utils.c    |   40 ++++++++++++++++++++--------------------
 5 files changed, 41 insertions(+), 33 deletions(-)


With friendly regards,
Takis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20070303T225603-ffmpeg-loggish_dump.diff
Type: text/x-patch
Size: 7562 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070303/da38c219/attachment.bin>