[Ffmpeg-devel] Mpeg2-ts encoder uses fixed PES payload size

[Aurelien Jacobs]

On Sun, 04 Mar 2007 12:30:32 +0100
Luca Abeni <lucabe72 at email.it> wrote:

> Hi Aurelien,
> 
> On Sun, 2007-03-04 at 02:29 +0100, Aurelien Jacobs wrote:
> [...]
> > > Index: libavformat/allformats.c
> > > ===================================================================
> > > --- libavformat/allformats.c	(revision 8205)
> > > +++ libavformat/allformats.c	(working copy)
> > > @@ -103,6 +103,7 @@
> > >      REGISTER_MUXER   (MPEG2VIDEO, mpeg2video);
> > >      REGISTER_MUXER   (MPEG2VOB, mpeg2vob);
> > >      REGISTER_DEMUXER (MPEGPS, mpegps);
> > > +    REGISTER_MUXER   (MPEGTS, dvb);
> > 
> > This looks wrong. Both parameters of REGISTER_MUXER should be
> > exactly the same, one uppercase and one lowercase.
> Well, my idea was that the DVB is always enabled and registered when the
> TS muxer is. So, I come up with this strange usage of the
> REGISTER_MUXER() macro. If this is wrong, I'll fix the patch and resend
> it.
> 
> > This should be:
> >   REGISTER_MUXER   (DVB, dvb);
> > And you should add a line in the Makefile:
> >   OBJS-$(CONFIG_DVB_MUXER) += mpegtsenc.o
> I was thinking about avoiding CONFIG_DVB_MUXER (my idea was: if
> CONFIG_MPEGTS_MUXER is defined, then both the TS and the DVB muxers are
> compiled - they are the same muxer - and enabled)... As said, if this is
> not acceptable I'll fix and resend the patch.

I perfectly understand your idea, but I think there's no reason to prevent
users to individually enable/disable every muxer/demuxer, even if two of
them share the exact same code (for now).

Aurel