[Ffmpeg-devel] [PATCH] use new way to handle "ab" option

[Benoit Fouet]

Quoting Michael Niedermayer <michaelni at gmx.at>:

> Hi
>
> On Sat, Mar 03, 2007 at 10:51:54PM +0100, Benoit Fouet wrote:
>> Hi,
>>
>> here is a proposal to change management of "ab" option in ffmpeg.c, so
>> that it works as "b" option.
>> there is also the adding of "vb" option, as it exists now...
>>
>> Note:
>>  - adding "-ab 64k" to ffmpeg command was the simpliest way i found
>> to update regression test script
>>  - in the regression test script, i also didn't change -b to -vb when
>> there was a -an option
>>
>> Thoughts ?
>
> [...]
>
>>      { "vframes", OPT_INT | HAS_ARG | OPT_VIDEO,   
>> {(void*)&max_frames[CODEC_TYPE_VIDEO]}, "set the number of video   
>> frames to record", "number" },
>> +    { "vb", OPT_FUNC2 | HAS_ARG | OPT_VIDEO, {(void*)opt_default},  
>>  "set video bitrate (in bits/s)", "bitrate", },
>>      { "dframes", OPT_INT | HAS_ARG,   
>> {(void*)&max_frames[CODEC_TYPE_DATA]}, "set the number of data   
>> frames to record", "number" },
>>      { "r", HAS_ARG | OPT_VIDEO, {(void*)opt_frame_rate}, "set   
>> frame rate (Hz value, fraction or abbreviation)", "rate" },
>>      { "s", HAS_ARG | OPT_VIDEO, {(void*)opt_frame_size}, "set   
>> frame size (WxH or abbreviation)", "size" },
>> @@ -3634,7 +3628,7 @@
>>
>>      /* audio options */
>>      { "aframes", OPT_INT | HAS_ARG | OPT_AUDIO,   
>> {(void*)&max_frames[CODEC_TYPE_AUDIO]}, "set the number of audio   
>> frames to record", "number" },
>> -    { "ab", HAS_ARG | OPT_AUDIO, {(void*)opt_audio_bitrate}, "set   
>> audio bitrate (in kbit/s)", "bitrate", },
>> +    { "ab", OPT_FUNC2 | HAS_ARG | OPT_AUDIO, {(void*)opt_default},  
>>  "set audio bitrate (in bits/s)", "bitrate", },
>>      { "aq", OPT_FLOAT | HAS_ARG | OPT_AUDIO,   
>> {(void*)&audio_qscale}, "set audio quality (codec-specific)",   
>> "quality", },
>
> why are the "vb" and "ab" needed here?
> doesnt it work without them too?
>
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> If you really think that XML is the answer, then you definitly missunderstood
> the question -- Attila Kinali
>