[Ffmpeg-devel] [PATCH] fix -ab default

[Benoit Fouet]

Hi,

Michael Niedermayer wrote:
> Hi
>
> On Tue, Mar 06, 2007 at 10:45:57PM +0100, Benoit Fouet wrote:
>   
>> Hi,
>>
>> Michael Niedermayer wrote:
>>     
>>> Hi
>>>
>>> On Tue, Mar 06, 2007 at 09:07:44PM +0100, Benoit Fouet wrote:
>>> [...]
>>>   
>>>       
>>>>> -{"b", "set bitrate (in bits/s)", OFFSET(bit_rate), FF_OPT_TYPE_INT, AV_CODEC_DEFAULT_BITRATE, INT_MIN, INT_MAX, V|A|E},
>>>>> +{"b", "set bitrate (in bits/s)", OFFSET(bit_rate), FF_OPT_TYPE_INT, AV_CODEC_DEFAULT_BITRATE, INT_MIN, INT_MAX, V|E},
>>>>> +{"ab", "set bitrate (in bits/s)", OFFSET(bit_rate), FF_OPT_TYPE_INT, 64*1000, INT_MIN, INT_MAX, A|E},
>>>>>   
>>>>>       
>>>>>           
>>>> why not a define, as for video one ?
>>>>     
>>>>         
>>> because it doesnt work
>>>
>>>
>>> [...]
>>>   
>>>       
>> well, either you didn't understand me, or i didn't understand you right
>> now :)
>>     
>
> hmm well i thought you meant
> {"b", "set bitrate (in bits/s)", OFFSET(bit_rate), FF_OPT_TYPE_INT, AV_CODEC_DEFAULT_BITRATE, INT_MIN, INT_MAX, V|E},
> {"b", "set bitrate (in bits/s)", OFFSET(bit_rate), FF_OPT_TYPE_INT, 64*1000, INT_MIN, INT_MAX, A|E},
>
> and that doesnt work currently
>
> if you meant AV_CODEC_DEFAULT_BITRATE, that of course can be done (later in a
> seperate patch)
>
>   
that is indeed what i meant
Ben