[Ffmpeg-devel] [PATCH] fix -ab default

[Baptiste Coudurier]

Hi

Michael Niedermayer wrote:
> Hi
> 
> attached patch adds a new avcodec_get_context_defaults2() and 
> avcodec_alloc_context2() which take an additional CodecType as argument
> 
> it adds a av_opt_set_defaults2() which has a flags parameter so only
> specific defaults are used
> 
> and it adds a -ab to AVOption whos flags specify that it only applies for
> audio and -b only applies to video
> 
> and last it makes ffmpeg.c use the new code
> 
> all that together fixes the -ab default (note the recent changes to
> command line option handling did not truly introduce this bug it was
> rather hidden by the old code ...)
> 
> so everyone who flamed please now read and comment! that is
> comment now not after i applied it!
> 
> is CodecType a good choice as argument for the default setting function?
> i choose it as it was slightly easier, alternatives are AVCodec and
> CodecID, the advantage of the later 2 would be that we would move
> toward being able to have per codec defaults which could come in handy
> for x264

Well, since we cannot afford to change API oftenly, would it be hard to
use CodecID now ? Im sure some people would be happy to start tweaking
x264 default settings.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312