[Ffmpeg-devel] [PATCH] remove the_end label
Michel Bardiaux
mbardiaux
Wed Mar 7 11:14:07 CET 2007
Limin Wang wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi,
>
> * Benoit Fouet <benoit.fouet at purplelabs.com> [2007-03-07 11:04:44 +0100]:
>
>> or, as Michel suggested:
>>
>> @@ -828,8 +828,6 @@
>> ost->sync_opts++;
>> ost->frame_number++;
>> }
>> - the_end:
>> + the_end:;
>
> Yes, but the_end label has lost its original function(help to do memory
> cleanup)? I think keep it there will confuse the future code reviewer.
>
If not used then by all means remove it, it will save a warning. I just
wanted to suggest how to code when a label *is* needed.
HaND,
--
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be
Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/
More information about the ffmpeg-devel
mailing list