[Ffmpeg-devel] [PATCH] separate AC-3 common code

[Michael Niedermayer]

Hi

On Thu, Mar 08, 2007 at 11:22:00PM -0500, Justin Ruggles wrote:
> Hello,
> 
> I split this change into 2 patches.  I don't know if it's better to
> apply both at the same time or to do it in 2 commits.
> 
> The first patch creates, but does not build or use, a new file ac3.c as
> svn copy of ac3enc.c.  It is trimmed to only have the core bit
> allocation and common initialization functions.
> 
> The second patch removes the common code from ac3enc.c, changes the
> shared tables to non-static with ff_ prefix, and enables compilation of
> ac3.c.

2 commits are always better then one if the change is large IMHO


> 
> One thing I'm not sure about is the best location for the fixed-point
> ac3_window table.  It will not be used by the decoder or the parser, so
> does it really belong in ac3tab.h?  Maybe it should be moved to
> ac3enc.c.  What do you think?

ok

and both patches look ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070309/1ffe53bf/attachment.pgp>