[Ffmpeg-devel] [PATCH] remove non library include header files

[Måns Rullgård]

Limin Wang <lance.lmwang at gmail.com> writes:

> Hi,
>
> I think ffmpeg.c shouldn't include the headers which aren't part of ffmpeg
> library header file. If anybody need dsputil.h and framehook.h, then install
> it as library header to include directory? Now without them, I can compile
> ffmpeg without issue by my configure. Please review the patch.
>
> One more question, any possible to move all library header files to every
> library include directory, so that we can get which is public header files
> easily? Now I had to check the install directory to sure which is public.
>
> Thanks,
> Limin
>
> Index: ffmpeg.c
> ===================================================================
> --- ffmpeg.c	(revision 8335)
> +++ ffmpeg.c	(working copy)
> @@ -23,8 +23,6 @@
>  #include <limits.h>
>  #include "avformat.h"
>  #include "swscale.h"
> -#include "framehook.h"

Isn't this required for vhooks?

> -#include "dsputil.h"

I don't think that header needs to be included here.  Removing that
line should be safe.

-- 
M?ns Rullg?rd
mans at mansr.com