[Ffmpeg-devel] [PATCH 22/31] Move av_realloc() to the header file.

[Panagiotis Issaris]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi

Aurelien Jacobs schreef:
> On Mon, 12 Mar 2007 15:50:35 +0100
> Panagiotis Issaris <takis.issaris at uhasselt.be> wrote:
>> Michael Niedermayer schreef:
>>> On Thu, Mar 08, 2007 at 10:09:05PM +0100, Panagiotis Issaris wrote:
>>>> Michael Niedermayer schreef:
>>>>> On Mon, Mar 05, 2007 at 04:28:47PM +0100, Panagiotis Issaris wrote:
>>>>>> Michael Niedermayer schreef:
>>>>>>> On Sun, Mar 04, 2007 at 11:11:47PM +0100, takis.issaris at uhasselt.be wrote:
>>>>>>>> Move libavutil/mem.c public API comments to common.h. The moved comments are
>>>>>>>> unmodified.
>>>>>>> i think mem.c should get its own mem.h besides this ive no
>>>>>>> objections to moving the comments to the header, if you like you can
>>>>>>> move all of the mem.c comments to common.h and later move them to mem.h
>>>>>> Should common.h include mem.h or should all files that need the memory
>>>>>> allocation functions directly include mem.h (that would be 141 files)?
>>>>> due to API compatibility common.h needs to #inlude it
>>>>> [...]
>>>> The attached patch moves the memory related function out of common.h
>>>> into their own header file mem.h.
>>>>
>>>>  common.h |   42 +---------------------------------------
>>>>  mem.h    |   65
>>>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>>  2 files changed, 67 insertions(+), 40 deletions(-)
>>> looks ok, and dont forget svn cp! (and check first that you didnt add any
>>> cosmetic chanegs by mistake (diff old common.h against mem.h)
>>>
>>> [...]
>> Applied.
>>
>> Should mem.h be installed on "make install"?
> 
> common.h is installed and it #include mem.h so installed common.h won't
> work until you install mem.h.
Indeed, that's yet another and even stronger reason...

> So I think that mem.h must be installed.
Thanks for replying! I just wanted to make sure I wasn't doing something
insane before committing this.

With friendly regards,
Takis

With friendly regards,
Takis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF9XHj9kOxLuzz4CkRAow0AJ4rrfZbDx2308Gi8gWR4Nb9cBCG6ACfXHsv
oCfTWp/UfNZoP0cXpB7q5+o=
=5a+G
-----END PGP SIGNATURE-----