[Ffmpeg-devel] [PATCH 12/31] Move rtp_parse_open() to the header file.

[Panagiotis Issaris]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi

Michael Niedermayer schreef:
> On Mon, Mar 12, 2007 at 04:21:33PM +0100, Panagiotis Issaris wrote:
>> takis.issaris at uhasselt.be schreef:
>>> Move libavutil/rtp.c public API comments to rtp.h. The moved comments are
>>> unmodified.
>>>
>>> Signed-off-by: Panagiotis Issaris <takis.issaris at uhasselt.be>
>>> ---
>>>  libavformat/rtp.c |    6 ------
>>>  libavformat/rtp.h |    7 +++++++
>>>  2 files changed, 7 insertions(+), 6 deletions(-)
>> Ping... :-)
>>
>> All other patches from the [xx/31] patchset have been reviewed and
>> applied, the only exceptions which received no comments were the ones
>> listed here:
>> [12/31] Move rtp_parse_open() to the header file.
>> [13/31] Move rtp_parse_packet() to the header file.
>> [14/31] Move rtp_set_remote_url() to the header file.
>> [15/31] Move rtp_get_local_port() to the header file.
>> [16/31] Move rtp_get_file_handles() to the header file.
>>
>> The descriptions are incorrect as the function itself isn't moved, but
>> the Doxygen comments only.
> 
> they move comments to rtp.h yes, that on its own would be all fine but
> rtp.h is a installed header and these functions dont look like they
> should be in a installed header
Okay, if you wouldn't mind I would still prefer to move them to the
header file (as long as a header file exists I think it is still useful).

> maybe rtp.h should not be installed at all i dunno
Oh, I see. I'll start a new thread to ask other for their opinion.

With friendly regards,
Takis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF9/Z+9kOxLuzz4CkRAhH9AJ9T9n17QB1m9FYYkj2GEmiRYS87BwCff3OL
Mpg6stk+fVQwgPSukEewpEc=
=e8j7
-----END PGP SIGNATURE-----