[Ffmpeg-devel] [PATCH] DVR-MS probe audio format - was DVR-MS bug (MP2 decoding)

[Michael Niedermayer]

Hi

On Thu, Mar 15, 2007 at 03:01:10PM -0500, John Donaghy wrote:
> >theres a ac3_probe in libaformar/raw.c, if it works with what is stored in
> asf
> >that i dunno
> >
> 
> I got a prototype of the proposed approach to work but I had to modify the
> ac3_probe function to read up to the first 'sync word'. Is that going to be
> acceptable?

well, think about it yourself :)

checking the first 16bits and then doing an additional 2 checks which together
have about a 1/2 chance of passing on random data will cause
1 missdetection in ~100000 random files

trying the same check everywhere in a buffer, lets say its 2kb large will
cause 1 out of 50 random files to be misdetected as ac3, thats not going to
work ...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070316/88e02d83/attachment.pgp>